Open
Conversation
| }) | ||
| } | ||
|
|
||
| function fetchForecast() { |
There was a problem hiding this comment.
check your code indentation. Its confusing and the scope is getting lost
| <img src="http://openweathermap.org/img/wn/${weather[0].icon}.png"> | ||
| `; | ||
| weatherInfo.html(currentWeatherHtml); | ||
| }) |
There was a problem hiding this comment.
Missing error call back. What happens if it fails?
| const forecastUrl = `${baseUrl}/forecast?q=${city}&appid=${apiKey}&units=imperial`; | ||
| fetch(forecastUrl) | ||
| .then(response => response.json()) | ||
| .then(data => { |
Comment on lines
+24
to
+31
| const { name, main, weather } = data; | ||
| const currentWeatherHtml = ` | ||
| <h2>Current Weather in ${name}</h2> | ||
| <p>Temperature: ${main.temp}°F</p> | ||
| <p>Conditions: ${weather[0].description}</p> | ||
| <img src="http://openweathermap.org/img/wn/${weather[0].icon}.png"> | ||
| `; | ||
| weatherInfo.html(currentWeatherHtml); |
There was a problem hiding this comment.
separating responsibilities and creating functions can help with readability.
This is not really fetching the weather, this is already rendering something... (hint for function name)
| fetch(forecastUrl) | ||
| .then(response => response.json()) | ||
| .then(data => { | ||
| const forecast = data.list.filter(item => item.dt_txt.includes('12:00:00')); |
There was a problem hiding this comment.
this is fine, but ideally you could have averaged the data according to the current time you are.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.